Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new platforms and clarify help message for check_platform #161

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Add new platforms and clarify help message for check_platform #161

merged 2 commits into from
Sep 11, 2024
+11 −2

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Aug 23, 2024 •
edited
Loading

This PR adds several satellites to the platforms.txt file. The sentinels (S1B, S2A/B) are added along with GOES-17, -18 and -19. I also added some missing Chinese satellites (FY-3E/F/G).

In addition, I updated the help message for the check_platform.py script to state that the satellite name must be given in upper case, as this confused me when I first ran the script.

Lastly, I updated the PR template to replace master with main.

@simonrp84 simonrp84 mentioned this pull request Aug 23, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (14db2a9) to head (03580df).
Report is 109 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          14       14           
  Lines        2265     2265           
=======================================
  Hits         1996     1996           
  Misses        269      269
Flag Coverage Δ
unittests 88.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Aug 23, 2024 •
edited
Loading

Coverage Status

coverage: 88.06%. remained the same
when pulling 03580df on simonrp84:AddSentinel
into 18abb61 on pytroll:main.

@adybbroe adybbroe requested review from adybbroe and sfinkens August 23, 2024 11:57
adybbroe
adybbroe approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! Not often I use the check_platforms.py script, didn't realize/remember it required uppercase!

@mraspaud mraspaud merged commit f581c44 into pytroll:main Sep 11, 2024
17 checks passed
@simonrp84 simonrp84 deleted the AddSentinel branch September 11, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfinkens sfinkens sfinkens approved these changes

@adybbroe adybbroe adybbroe approved these changes

Assignees

@simonrp84 simonrp84

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SENTINEL-2 TLE files
5 participants
@simonrp84 @coveralls @adybbroe @sfinkens @mraspaud